Skip to content

Implement the findroute, findroutetonode and findroutebetweennodes commands#21

Open
mohitk108 wants to merge 4 commits intoACINQ:masterfrom
mohitk108:routes
Open

Implement the findroute, findroutetonode and findroutebetweennodes commands#21
mohitk108 wants to merge 4 commits intoACINQ:masterfrom
mohitk108:routes

Conversation

@mohitk108
Copy link
Contributor

@mohitk108 mohitk108 commented Aug 17, 2023 •
edited
Loading

The implementations of these commands are added through this PR.
Code for autocompletion and unit tests, for the respective commands are also added.
To see the documentation of these commands, kindly refer : API Documentation

t-bast
t-bast reviewed Aug 18, 2023
View reviewed changes
src/nativeTest/kotlin/mocks/EclairClientMocks.kt Outdated
]
}
"""
val validFindRouteToNodeResponse = """{
Copy link
Member

@t-bast t-bast Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're only testing the case where format=nodeId, you need to also test the format=shortChannelId and format=full cases.

Copy link
Contributor Author

@mohitk108 mohitk108 Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll cover them soon.

@mohitk108
Copy link
Contributor Author

mohitk108 commented Aug 19, 2023

I've added the test for different cases, like format=nodeId and sshortChannelId as well in 9f6f5fa for the findroute command.
The build will fail right now, since I've modified the EclairClientMocks. I will update the remaining tests once you approve this particular change.
You can individually run the test right now. It's passing for me.

@t-bast
Copy link
Member

t-bast commented Aug 21, 2023

I will update the remaining tests once you approve this particular change.

I'm not sure what particular change you want me to review before finishing the work?
You should simply finish updating the tests and then I'll be able to review it?

@mohitk108 mohitk108 requested a review from t-bast August 31, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-bast t-bast Awaiting requested review from t-bast

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mohitk108 @t-bast